Skip to content

Update basic-segmented-bar example #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Update basic-segmented-bar example #200

merged 1 commit into from
Jul 25, 2017

Conversation

vchimev
Copy link

@vchimev vchimev commented Jun 13, 2017

A few ideas for improvements ... :)

@vchimev vchimev requested a review from NickIliev June 13, 2017 15:44
Copy link
Contributor

@sis0k0 sis0k0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.myItems = Array.from(Array(5))
    .map(_ => new SegmentedBarItem())
    .map((item, i) => {
        item.title = `Tab ${i}`;
        return item;
    });

and if we supported object destructuring even:

this.myItems = Array.from(Array(5))
    .map(_ => new SegmentedBarItem())
    .map((item, i) => <SegmentedBarItem>({...item, title: `Tab ${i}`}));

@vakrilov vakrilov merged commit a6d4390 into master Jul 25, 2017
@vakrilov vakrilov deleted the vchimev-bar branch July 25, 2017 07:47
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants